Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid monster flag: "CAN_BE_ORDERED" #4487

Closed
scarf005 opened this issue Apr 15, 2024 · 3 comments
Closed

invalid monster flag: "CAN_BE_ORDERED" #4487

scarf005 opened this issue Apr 15, 2024 · 3 comments

Comments

@scarf005
Copy link
Member

scarf005 commented Apr 15, 2024

DEBUG    : Error: Json error: data/json/monsters/drones.json:18:100: invalid monster flag: "CAN_BE_ORDERED"

e": "collection", "groups": [ [ "robots", 80 ] ], "//": "80% chance of an item from group robots" },
   "death_function": [ "BROKEN_AMMO" ],
   "flags": [ "SEES", "FLIES", "NOHEAD", "ELECTRONIC", "NO_BREATHE", "INTERIOR_AMMO", "BIOPROOF", "
                                                                                                  ^
                                                                                                   CAN_BE_ORDERED" ]
 },
 {


FUNCTION : bool main_menu::load_character_tab(const std::string &)
FILE     : /home/scarf/repo/cata/Cataclysm/src/main_menu.cpp
LINE     : 1020
VERSION  : BN HEAD-HASH

prevents the game from loading. happens on all saves. not sure why invalid flags prevent the game from loading at all.

@chaosvolt
Copy link
Member

Uh, what? That's from #4247

The flag should be 100% valid, it was tested by both of us.

@scarf005
Copy link
Member Author

hecc, for some reason can't reproduce after recompilation.

@scarf005 scarf005 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
@chaosvolt
Copy link
Member

Just downloaded build 2024-04-14, started a world, spawned a manhack, saved, then loaded. Couldn't reproduce it.

Probably came from loading an exe compiled from an old branch predating the PR being merged (since monster flags are all defined in the code, not in JSON like item flags) after updating the branch from upstream.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants