Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch_xmlwriter build error gcc 13,14 #2907

Closed
dakka opened this issue Sep 14, 2024 · 1 comment
Closed

catch_xmlwriter build error gcc 13,14 #2907

dakka opened this issue Sep 14, 2024 · 1 comment
Labels

Comments

@dakka
Copy link

dakka commented Sep 14, 2024

Describe the bug
Compilation error C++20

gcc 12 ok, 13 and 14 error

/home/davidd/prog/fiber_new/build/_deps/catch2-src/src/catch2/../catch2/internal/catch_xmlwriter.hpp:18:10: warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword
|     enum class XmlFormatting : uint8_t {
|     ~~~~ ^~~~~
/home/davidd/prog/fiber_new/build/_deps/catch2-src/src/catch2/../catch2/internal/catch_xmlwriter.hpp:18:30: error: found ‘:’ in nested-name-specifier, expected ‘::’ 
   18 |     enum class XmlFormatting : uint8_t { 

Expected behavior
Should compile

Platform information:

  • OS: Ubuntu 24.04.1 LTS
  • Compiler+version: GCC v14.01 g++ -ggdb -O3 -std=gnu++20
  • Catch version: devel

Built in cmake using fetchcontent

Suggested fix

#include <cstdint>
@dakka dakka changed the title catch_xmlwriter build error gcc 14 catch_xmlwriter build error gcc 13,14 Sep 15, 2024
@horenmar horenmar added the Bug label Sep 15, 2024
@dakka
Copy link
Author

dakka commented Sep 16, 2024

Thanks for sorting that out so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants