Skip to content

Commit 5b475b5

Browse files
committed
Merge branch 'master' into gentle-mite
2 parents d9e81a8 + f6dba94 commit 5b475b5

37 files changed

+15
-625
lines changed

bin/webpagetest

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,13 @@ var formatData = function(err, data, info) {
5959
}
6060

6161
if (file) {
62-
fs.writeFile(file, dataStr, encoding, function writeFile(err) {
62+
fs.writeFile(file, (dataStr || data), encoding, function writeFile(err) {
6363
if (err) {
6464
output(err.message, 1);
6565
}
6666
});
6767
} else {
68-
output(dataStr, err ? 1 : 0);
68+
output((dataStr || data), err ? 1 : 0);
6969
}
7070

7171
return data;

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "webpagetest",
3-
"version": "0.7.4",
3+
"version": "0.7.5",
44
"description": "WebPageTest API wrapper for NodeJS",
55
"author": "WebPageTest <github@WebPageTest.com> (http://github.com/WebPageTest)",
66
"homepage": "http://github.com/WebPageTest/webpagetest-api",

test/command-line-test.js

-19
Original file line numberDiff line numberDiff line change
@@ -322,25 +322,6 @@ describe('WebPageTest Command Line', function() {
322322
});
323323
});
324324

325-
// loop all commands help
326-
[
327-
'', 'status', 'results', 'locations', 'testers', 'test', 'testAndWait', 'restart', 'cancel', 'har',
328-
'pagespeed', 'utilization', 'request', 'timeline', 'netlog', 'chrometrace',
329-
'console', 'testinfo', 'history', 'googlecsi', 'response', 'waterfall',
330-
'screenshot', 'video', 'player', 'listen', 'batch','testBalance'
331-
].forEach(function eachCmd(command) {
332-
it('gets a ' + command + ' help input and returns the help text', function(done) {
333-
exec(mock(command + ' --help'), function(err, data) {
334-
if (err) return done(err);
335-
data = data.replace(/[\r\n\s]/g, '');
336-
var output = getHelp(command);
337-
output = output.replace(/[\r\n\s]/g, '');
338-
assert.equal(data, output);
339-
done();
340-
});
341-
});
342-
});
343-
344325
it('gets a batch input returns the batch commands output in order', function(done) {
345326
exec(mock('batch ' + path.join(__dirname, 'fixtures/batch.txt')), function(err, data) {
346327
if (err) return done(err);

test/dryrun-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ var assert = require('assert'),
99
WebPageTest = require('../lib/webpagetest');
1010

1111
var wptServer = 'https://www.example.com:1234/foo/bar/',
12-
wpt = new WebPageTest(wptServer);
12+
wpt = new WebPageTest(wptServer, 'YOURAPIKEY');
1313

1414
describe('Dry Run', function() {
1515
describe('An Example WebPageTest Server', function() {

test/edge-cases-test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
var assert = require('assert'),
99
os = require('os'),
1010
WebPageTest = require('../lib/webpagetest'),
11-
helper = require('../lib/helper'),
12-
packageJson = require('../package.json');
11+
helper = require('../lib/helper')
1312

1413
var wptServer = 'https://www.example.com:1234/foo/bar/';
14+
var MOCK_KEY = '0987654321';
1515

1616
describe('Edge Cases of', function() {
1717
describe('An HTTPS WebPageTest Server with API key', function() {
@@ -20,7 +20,7 @@ describe('Edge Cases of', function() {
2020
it('gets a simple test request with another HTTP server and API key then returns API url', function(done) {
2121
wpt.runTest('http://foobar.com', {
2222
server: 'http://wpt.com',
23-
key: '0987654321',
23+
key: MOCK_KEY,
2424
dryRun: true
2525
}, function (err, data) {
2626
if (err) return done(err);
@@ -36,7 +36,7 @@ describe('Edge Cases of', function() {
3636
it('gets a simple test request with another HTTPS server and API key then returns API url', function(done) {
3737
wpt.runTest('http://foobar.com', {
3838
server: 'https://wpt.com:4321/baz/',
39-
key: '0987654321',
39+
key: MOCK_KEY,
4040
dryRun: true
4141
}, function (err, data) {
4242
if (err) return done(err);

test/fixtures/command-line/help-batch.txt

-6
This file was deleted.

test/fixtures/command-line/help-cancel.txt

-8
This file was deleted.

test/fixtures/command-line/help-chrometrace.txt

-9
This file was deleted.

test/fixtures/command-line/help-console.txt

-9
This file was deleted.

test/fixtures/command-line/help-googlecsi.txt

-9
This file was deleted.

test/fixtures/command-line/help-har.txt

-6
This file was deleted.

test/fixtures/command-line/help-history.txt

-6
This file was deleted.

test/fixtures/command-line/help-listen.txt

-8
This file was deleted.

test/fixtures/command-line/help-locations.txt

-10
This file was deleted.

test/fixtures/command-line/help-netlog.txt

-9
This file was deleted.

test/fixtures/command-line/help-pagespeed.txt

-9
This file was deleted.

test/fixtures/command-line/help-player.txt

-6
This file was deleted.

test/fixtures/command-line/help-request.txt

-9
This file was deleted.

test/fixtures/command-line/help-response.txt

-10
This file was deleted.

test/fixtures/command-line/help-restart.txt

-8
This file was deleted.

test/fixtures/command-line/help-results.txt

-24
This file was deleted.

test/fixtures/command-line/help-screenshot.txt

-17
This file was deleted.

test/fixtures/command-line/help-status.txt

-7
This file was deleted.

0 commit comments

Comments
 (0)