Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install and develspace interplay #69

Closed
NikolausDemmel opened this issue Jun 11, 2014 · 5 comments
Closed

build: install and develspace interplay #69

NikolausDemmel opened this issue Jun 11, 2014 · 5 comments

Comments

@NikolausDemmel
Copy link
Member

I just noticed these issues following a discussion in #64 (comment):

Calling catkin build --install after catkin build is broken for pure cmake packages. After the first call they will have been installed into the devel space and the second call will not install them to the source space.

Edit: I moved the second issue to #70

@wjwwood
Copy link
Member

wjwwood commented Jun 11, 2014

This is because catkin build does not --force-cmake when the --install option is added, this should be the case and is a scenario where catkin_make_isolated behaves correctly but catkin build does not.

This is related to #11 because these will both be accomplished by introducing some state-fullness to the workspace using a marker file, probably in the build space, with the settings used to build embedded into them. Then when ever a change is detected --force-cmake can be applied, which should cause the linking to update.

@NikolausDemmel
Copy link
Member Author

@wjwwood: Your answer is addressing the first issue I raised, right? For that it makes much sense.

The second issue is happending when catkin build --install is invoked in a clean workspace (where catkin build has not been invoked before), so I'm not sure how --force-cmake might be relevant? (I should have opened two separate issues really...)

@wjwwood
Copy link
Member

wjwwood commented Jun 11, 2014

Oh, I didn't notice that, I'm not sure, I'd have to reproduce that and look more closely.

@NikolausDemmel
Copy link
Member Author

I will open a separate ticket and edit this ticket, since it seems they are quite different issues.

@jbohren jbohren added this to the Recommend Switch from CM / CMI milestone Jun 11, 2015
@jbohren jbohren changed the title install and develspace interplay build: install and develspace interplay Jun 11, 2015
@jbohren jbohren added the bug label Jun 11, 2015
@jbohren
Copy link
Contributor

jbohren commented Jan 23, 2016

Since merging #249, installing is now fixed for pure CMake packages.

@jbohren jbohren closed this as completed Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants