Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integration_default): override enabled key only if integration has one #559

Merged
merged 1 commit into from
Jul 29, 2023
Merged

fix(integration_default): override enabled key only if integration has one #559

merged 1 commit into from
Jul 29, 2023

Conversation

mrtnvgr
Copy link
Contributor

@mrtnvgr mrtnvgr commented Jul 28, 2023

Fixes #558

@mrtnvgr mrtnvgr merged commit 9709f82 into main Jul 29, 2023
@mrtnvgr mrtnvgr deleted the fix/integration_default branch July 29, 2023 05:49
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
Merged
@rewhile
Copy link
Contributor

rewhile commented Jul 29, 2023

integration_default = true will result into this error:

image

PLEASE test your PR before merging :)

mrtnvgr added a commit that referenced this pull request Jul 29, 2023
@mrtnvgr
fix(integration_default): hotfix for #559
4913a8b
@rewhile
Copy link
Contributor

rewhile commented Jul 29, 2023

@mrtnvgr Now the error is even longer :)

image

@mrtnvgr
Copy link
Contributor Author

mrtnvgr commented Jul 29, 2023

@mrtnvgr Now the error is even longer :)

image

Omggggggg

@rewhile rewhile mentioned this pull request Jul 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When integration_default is set to true, barbecue fails
2 participants
@mrtnvgr @rewhile