-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract data sources to its own dedicated file #1021
Conversation
Hey @lmilbaum! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
14ed08f
to
1f33698
Compare
Refactoring the
and put the What do you think? |
I like the suggested approach. Will push a change soon. |
Sorry, wasn't aware that there are only some data sources. Thought we have many more. So I combined everything into one file again. One file per data source is too much overhead. |
Thanks for investing your time to improve the module, @lmilbaum. |
Description
Reducing main.tf file size will improve its readability. The data sources are moved to a separate file.
Migrations required
Nn
Verification
No verification done. Just moving the data sources.