-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for session_server #92
Comments
@roock cool idea, any idea thoughts for an implementation? |
some thoughts:
|
Oh yes, a feature I missed already. Guess no work is going on at the moment, right? |
Yep, no development is going on, feel free to create a PR |
The EIP is assigned to the runner agent. #124 will not be solved here. |
I reviewed my last comment and think that it makes no sense to add an IP or load balancer or something else. The reason is, that you should already been able to reach the runner from your gitlab instance (to start the build jobs). |
Afaik there is a difference between regular runner jobs and the session Server. For regular jobs, the runner will establish a http connection to the gitlab server. For the session server, Gitlab will establish a (tls-encrypted) connection to the runner, so you will need to expose the session service to Gitlab. |
Oh yes, you are absolutely right. I will add options for an IP address and a load balancer (ALB, ELB do not work here, see https://docs.gitlab.com/ee/administration/integration/terminal.html#enabling-and-disabling-terminal-support) |
The module already supports adding an EIP directly to the instance. Not sure if it is strictly required to put it behind a ALB, although it might be a more elegant solution. |
@roock Yeah, just saw it. So nothing to do for the EIP. An ALB listener can now be passed to the module. But the test is still missing. The idea is to use either EIP or ALB. Depends on your preferences, company guidelines, ... |
Hm, still on my wishlist. Using an ALB is too complicated. Let's stick with the EIP solution which is already in place. |
Ok, let's give it another try. Stick with EIP for the base feature and add ALB support later. |
Was there any progress toward this? :) |
No progress at all. Any ideas? |
It would be cool if we could support session_server in the gitlab runner config for interactive webterminals
https://docs.gitlab.com/ee/ci/interactive_web_terminal/index.html
https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-session_server-section
The text was updated successfully, but these errors were encountered: