fix: convert the fleet instance type in migration script #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The instance types for the fleet are not converted. In this case the module uses a default value
m5.large
. So all created instances arem5.large
instances which is usually not wanted.If the migration script was used to convert the module call to version 7, it is very likely that you find the following in your module call:
The variable
docker_machine_types_fleet
does not exist, but Terraform does not report an error.This PR fixes the migration script and produces the following correct code:
Migrations required
No
Verification
Verified locally that the script produces the output as described above.