Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding #22

Closed
gondo opened this issue Nov 12, 2015 · 5 comments
Closed

encoding #22

gondo opened this issue Nov 12, 2015 · 5 comments

Comments

@gondo
Copy link
Contributor

gondo commented Nov 12, 2015

one of the parameter for constructor in AbstractDiff class is $encoding, however this is not used anywhere.
is something missing? what is the point of it?

@jschroed91
Copy link
Member

@gondo Good point... I took a look at the upstream repo and it's not being used there either... do you have a need for implementation of handling encoding?

@gondo
Copy link
Contributor Author

gondo commented Feb 22, 2016

replace every string related function with its mb_* equivalent
http://php.net/manual/en/book.mbstring.php

@jschroed91
Copy link
Member

Sounds good!

@jschroed91
Copy link
Member

@gondo Just an update - I plan to include implementation for encoding in the next release. Aiming for 1-2 weeks.

@jschroed91 jschroed91 added this to the v0.1.1 milestone Mar 14, 2016
@jschroed91 jschroed91 self-assigned this Mar 14, 2016
@jschroed91 jschroed91 removed this from the v0.1.1 milestone Mar 16, 2016
@jschroed91 jschroed91 removed their assignment Aug 26, 2016
@jschroed91
Copy link
Member

I believe the changes made in #72 address these issues. Please reopen this issue if that's not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants