Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes if string contains "Р" character (uppercase cyrillic Р letter) #58

Closed
Rastishka opened this issue Nov 25, 2016 · 4 comments
Closed
Labels

Comments

@Rastishka
Copy link

Please add "/u" (PCRE_UTF8) modifier to regexps, if $config->setEncoding('UTF-8') is set.

@jschroed91 jschroed91 added the Bug label Nov 25, 2016
@jschroed91
Copy link
Member

Thank you for submitting this issue @Rastishka - I will be able to make this change sometime this weekend, but if you need it sooner feel free to fork and make the changes and open a pull request!

@SavageTiger
Copy link
Contributor

SavageTiger commented May 4, 2017

Hi Josh,

I took the time to look at this issue. However it seems invalid. I cannot for the live of me reproduce this issue. Maybe its only present in a certain PHP version.

Testing the following fixture seems to work fine:

<oldText>
<div>Р ҦԤП п; italics: П п</div>
</oldText>

<newText>
<div>Its all gone!</div>
</newText>

<expected>
<div><del class="diffmod">Р ҦԤП п; italics: П п</del><ins class="diffmod">Its all gone!</ins></div>
</expected>

Maybe the ticket should be closed?

@jschroed91
Copy link
Member

@Rastishka Closing this issue based on comment above - if this is still an issue please reopen and provide example text input for us to reproduce

@jschroed91
Copy link
Member

Thank you @SavageTiger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants