Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.RemoveNode should accept an IRI instead of opaque node #607

Closed
oren opened this issue May 26, 2017 · 0 comments
Closed

store.RemoveNode should accept an IRI instead of opaque node #607

oren opened this issue May 26, 2017 · 0 comments

Comments

@oren
Copy link
Member

oren commented May 26, 2017

store.RemoveNode(node) removes all quads which have the given node as subject, predicate, object, or label. Currently it accepts an opaque node.

For example:

idIRI := quad.IRI(id)
node := store.ValueOf(id)
err := store.RemoveNode(node)

(store.ValueOf returns an opaque node)

We had a discussion about it on discourse and agreed that there is no need to expose the opaque node to the user and store.RemoveNode can accept IRI.
The new API will look like this:

idIRI := quad.IRI(id)
err := store.RemoveNode(idIRI)

This will help new users since they don't need to be aware of the lower level concept of opaque node.

@dennwc dennwc closed this as completed in b3e18e8 May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant