Improvements for FAN usage

[greensouth]

Hi! I previously tried to implement a more intuitive logic for the FAN in a previous (and quite obsolete) version of the plugin, but finally stopped because had to rewrite a huge amount of code which is already written in this branch.

So, if it could helps, here it goes my thoughts:

• If the unit is OFF, and FAN is turned ON or SPEED is CHANGED -> Turn the unit ON with FAN mode
• If the unit is ON, with any mode set, and FAN is switched OFF -> Set the FAN to AUTO, and unit keeps ON
• If the unit is switched to OFF from a previously ON state, regardless the mode, set both the FAN and UNIT to OFF

The idea is simple: if heater/cooler is OFF, the FAN controls the FAN mode of the unit
If the cooler/heater is ON, the FAN controls its speed, (auto on FAN OFF) and silent mode (maybe from a percentage to a percentage, like actually)

Hope this could help to improve the usability of the plugin.

Great work btw!

[awarburt]

Hi @greensouth Those sound like excellent suggestions. I think they would also address the (auto-closed) issue #65 #65 that I raised and that has not yet been addressed. Of possible relevance: a recent update of homebridge-config-ui-x mentioned some new "heater" and "cooler" functionalities in Homebridge -- perhaps these could help facilitate implementation of suggestions like these?

[atr00]

Agreed on this, that would be a great way to implement the FAN logic.

[MichelRabozee]

As before, I concur. I always modify my local copy of index.js to include the very few lines needed. Maybe it can be done through an option in the config (so people are free to link or not the fan with the unit). I also comment out some « if » conditions in order to let the unit answer its state even if it is OFF.

[cbrandlehner]

There were some changes to FAN mode in 2021.24.1 as setting FAN and DRY mode in the configuration did not work.
Can you please test again with the new version?

[MichelRabozee]

Hello, the new version still works for me, but I do not have any unit implementing the "DRY" mode hence I do not know if my answer is relevant.

BTW, I saw something strange (also in 2021.20.3 and forgot to report it): in "setSwingMode" for instance, it used to replace "b_f_dir", now it reads "b f_dir" (with a "space" instead of an "underscore"). I do not know if it is intended and if it does work like that ???

Same in "setFanStatus" where "f_rate" became "f rate" with space instead of underscore.

Also, I see that for each unit, at least on startup, 2 warning are generated (I guess this is since HomeBridge 1.3.x):

[14/06/2021 08:54:10] [homebridge-daikin-local] This plugin generated a warning from the characteristic 'Heating Threshold Temperature': characteristic value expected valid finite number and received "NaN" (number). See https://git.io/JtMGR for more info.
[14/06/2021 08:54:07] [homebridge-daikin-local] This plugin generated a warning from the characteristic 'Cooling Threshold Temperature': characteristic value expected valid finite number and received "NaN" (number). See https://git.io/JtMGR for more info.

Keep up the good work,
Michel

[cbrandlehner]

@MichelRabozee that "b_f_dir" issue is a bug. It was introduced by editing the code with an editor which replaced underscored with blanks. After that "accident" I tried to fix the code but clearly missed this one. Thanks for reporting it.

With HomeBridge 1.3.4 I do not see the warnign when starting up. This seems to be either configuration specific or device specific. Can you please start homebridge in Debug mode and provide more context to that warning?

[MichelRabozee]

Hello,

regarding the warnings, I do not see them on the new restart anymore. Maybe a glitch on the first restart with the new plugin needing to update its cache ? Anyway, seems solved by itself :-)

PS: in case you missed a part of my comment (as you mention only b_f_dir), regarding the space instead of underscore, there is also : f_rate <-> f rate

[cbrandlehner]

@MichelRabozee I hope I found all missing underscores.
New release published a minute ago for retesting.

[MichelRabozee]

No issue on my side with version 2021.25.1 !

[atcodrinky]

Just upgraded your plugin to version 2021.25.4 (on a docker on my Synology NAS) and I noticed that, when AC is ON in cool mode, if I set the fan to any percentage the AC turns in fan mode. Before this update I'm almost sure I was able to set fan speed of AC. Did I miss something?
Hope to have been clear in explanation.

[cbrandlehner]

@maverick464 you are correct. I had to change line 791 from
if (responseValues.pow === 1 && responseValues.mode === 3) {
to
if (responseValues.pow === '1' && responseValues.mode === '3') {

[cbrandlehner]

@maverick464 please retest with release 2021.26.1

[atcodrinky]

@cbrandlehner just checked latest release and all seem to be working fine again. Thanks a lot for the great work!!!

[cbrandlehner]

Closing - fixed as per user feedback.