Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fan Speed from 0 to 7 instead of 0-100% #78

Open
jeremybdk opened this issue Jul 14, 2020 · 8 comments
Open

Improve Fan Speed from 0 to 7 instead of 0-100% #78

jeremybdk opened this issue Jul 14, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@jeremybdk
Copy link

jeremybdk commented Jul 14, 2020

Is your feature request related to a problem? Please describe.
Homekit allows you to define a range of possible value for the fan speed instead of the default 0-100%

Describe the solution you'd like
I would love to have something like this:
I edited this plugin to make this video, but it misses the correct mapping back to the Daikin API.

RPReplay_Final1594719329

The code needed to do this is:

.setProps({ unit: null, format: Characteristic.Formats.UINT8, maxValue: 7, minValue: 1, validValues: [1, 2, 3, 4, 5, 6, 7] })

I think that should be easier for everyone, the only thing to manage is the Silent and AutoMode to map them to some Value.
The documentation is here: https://github.com/homebridge/HAP-NodeJS/blob/master/src/lib/gen/HomeKit.ts Line 594

Let me know If I can help,

@jeremybdk jeremybdk changed the title Improve Fan Speed with Defined Scale instead of 0-100% Improve Fan Speed from 0 to 7 instead of 0-100% Jul 14, 2020
@jeremybdk
Copy link
Author

jeremybdk commented Jul 16, 2020

I can try to work on this, but I still need to figure out how to manage Silent and Auto Mode, I was thinking that 8 could become the Auto Mode, but what about the Silent mode, how should I map it? Any Idea? @cbrandlehner what do you think? Is this something that you would be interested in?

@awarburt
Copy link

In case it's helpful, I dug up some related info on the mapping of AUTO and SILENT here: #65

@jonathan-catt
Copy link

In case it's helpful, I dug up some related info on the mapping of AUTO and SILENT here: #65

I was actually thinking about this. I am just coming up to speed with homebridge plugins from a technical standpoint, so apologies if this is incorrect. Perhaps it makes sense to use additional switch service for the mapping of Auto, and then leave Silent at mode 1, with the rest of the range in steps above it.

Furthermore, we could also potentially use switch services to enable things like intelligent eye and comfort / powerful mode for units that accept such parameters. The one thing I am not sure of is if you can turn off one service with another. For example, if you enabled auto mode, the fan service governing the fan speed should show that device is off. Additionally comfort mode also takes control of the fan speed so would need to work similarly. I think this would just be a UI difference and not change the commands sent to the unit. Thoughts?

(Appreciate any info if I am entirely off base here)

@jeremybdk
Copy link
Author

I think that's possible, by using the mapping to show the fan as Off when auto or other fan mode are enabled using additional switches. I wonder what @cbrandlehner think about it and if it's something he wants to add in the project.

@graanco
Copy link

graanco commented Dec 9, 2020

I was thinking on this issue and shouldn’t we just add a switch to the device linked... I think that would be easier... and if you still want to use the fan part... make it show when needed... same goes for the vanes...

@cbrandlehner cbrandlehner added the enhancement New feature or request label Jun 13, 2021
@graanco
Copy link

graanco commented Sep 11, 2021

Hmmm maybe this might be the answer… we need a multi select switch. Best one I’ve seen so far is the TV. Could that be used instead?.. think set propers on the tv 1-7 ,A,S you could even name them. I wish that we could add images as a selected item.

@cbrandlehner
Copy link
Owner

This is the current mapping of fan speeds.

Bild 18 08 23 um 13 28

@Tellicious
Copy link

Is there any plan to implement this? It shouldn't be too difficult to:

  • Change fan service to 1-7 (according to the levels already existing and showed above by @cbrandlehner)
  • Add a switch sub-service for Powerful mode (if someone can point me out to the command to be sent to the AC unit)

I might give it a try in the next weeks, if no one else is working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants