Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: missing type repository_ruleset #94

Open
rbtcollins opened this issue Sep 26, 2024 · 3 comments
Open

feature: missing type repository_ruleset #94

rbtcollins opened this issue Sep 26, 2024 · 3 comments

Comments

@rbtcollins
Copy link

repository_rule is defined.

I'm not sure if you're using code generation or artisanal definitions, but would be willing to make a patch, unless new types are super easy for you :)

@cbrgm
Copy link
Owner

cbrgm commented Sep 27, 2024

Heyho,

added the necessary parameters here. Sadly the event type is not available in the main google/go-github repository and has to be added there first. You can raise and issue there if you want, could be a cool first contribution, otherwise I'll do it probably in the next days.

Cheers!

@rbtcollins
Copy link
Author

Great, thanks! I've filed an issue which obviously doesn't do the work, but does let folk know.

I doubt I'll get the CLA approved by legal in order to submit a patch to go-github in the short term :/. If only it was DCO or simple FLOSS.

@cbrgm
Copy link
Owner

cbrgm commented Oct 23, 2024

Nice, it was merged last week. I'm waiting for the v67 release and will add the new webhook type then. Thanks for raising the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants