Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Join separated client and server page components #934

Closed
3 tasks done
brenoferreira opened this issue May 12, 2020 · 0 comments · Fixed by #1048
Closed
3 tasks done

Join separated client and server page components #934

brenoferreira opened this issue May 12, 2020 · 0 comments · Fixed by #1048
Assignees
Labels
💻 aspect: code Concerns the software code in the repository help wanted Open to participation from the community

Comments

@brenoferreira
Copy link
Contributor

brenoferreira commented May 12, 2020

Because of legacy issues, there are three pages that have separate server and client versions:

  • BrowsePage
  • CollectionsBrowsePage
  • PhotoDetailPage

The reason for that is that for some time we used a JS library to render the image grid. This library used browser specific APIs to render the image grid. Therefore it didn't work on the server renderer. So we had to split those pages into two different versions, one that didn't render the image grid (for the server) and another that did render it (for the client).

But in #538 we dropped the usage of Masonry Layout in favor of a CSS-only implementation of the image grid. This should make it possible to join those pages that are split into two different client and server versions. It should also make it possible to have a single router file.

It should be possible to:

  • delete the server versions of the page components
  • bring the code of the mixins back into the client specific page components (with the exception of ServerPrefetchProvidersMixin which is used for different purposes)
  • delete the server router and have a single router file (caveats: check the behaviour of scrollBehavior in the client router on the server.
@brenoferreira brenoferreira added enhancement help wanted Open to participation from the community labels May 12, 2020
@obulat obulat mentioned this issue Jun 1, 2020
7 tasks
@zackkrida zackkrida self-assigned this Jul 9, 2020
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository and removed tech labels Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository help wanted Open to participation from the community
Development

Successfully merging a pull request may close this issue.

3 participants