Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory peripherals don't support transfer api #88

Open
MattiDragon opened this issue Apr 26, 2022 · 7 comments
Open

Inventory peripherals don't support transfer api #88

MattiDragon opened this issue Apr 26, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@MattiDragon
Copy link

If you try to interact with any block that uses the fabric transfer api using the inventory peripheral it simply won't be detected. Many mods have started exclusively using this api for their inventories and such compatibility will only get worse over time if this isn't fixed. I don't see logs being useful and for reference I'm using minecraft 1.18.2 with cc-restitched 1.100.5.

@MattiDragon MattiDragon added the bug Something isn't working label Apr 26, 2022
@Merith-TK
Copy link
Collaborator

Merith-TK commented Apr 26, 2022

Will look into it, been a while since I personally took a look at the code.

As always, PR's are always welcome

@Patbox Patbox added enhancement New feature or request and removed bug Something isn't working labels Apr 26, 2022
@toad-dev
Copy link
Member

Can you give an example of some blocks that you think should work but don't? It would be helpful.

@MattiDragon
Copy link
Author

You can test it on many mods, but an easy one would be my drawers mod. Hoppers can interact with them due to a fapi patch (and so can other transfer mods), but cc can't.

@leo60228
Copy link

leo60228 commented Jul 6, 2022

This seems to also affect Create belts, but that might be a separate issue?

@Merith-TK
Copy link
Collaborator

Merith-TK commented Jul 6, 2022

try with this mod
https://www.curseforge.com/minecraft/mc-mods/unlimitedperipheralworks

this is currently mod that adds support for Transfer API (functions kinda like the Fluid API according to documentation)

unfortunately we cannot properly add support for the Transfer API as of this moment as it will require basically an complete rewrite of the inventory code to my knowlede

@luiz00martins
Copy link

luiz00martins commented Mar 6, 2023

Can you give an example of some blocks that you think should work but don't? It would be helpful.

Some other examples of this are the Modern Industrialization Barrels & Machines, and the DankStorage Danks.

You can test this on AOF6. None of them will connect to the Modem.

@MattiDragon
Copy link
Author

Transfer api recently added an optional slot system. Would it be possible to support that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants