Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card block header hierarchy #167

Open
phette23 opened this issue Dec 5, 2024 · 0 comments
Open

Card block header hierarchy #167

phette23 opened this issue Dec 5, 2024 · 0 comments
Labels

Comments

@phette23
Copy link
Member

phette23 commented Dec 5, 2024

Card blocks use an h4 but appear in the main body content where I think they need to be h3. We probably cannot actually fix this without really complicated code that dynamically chooses the heading level based on other content (because whether or not there is a subheading before the card changes what level it should be) but we can at least make it correct in the most common case of h1 page title > h2 subheading > h3 card header.

This happens in the card.html template.

Highlighted by the Wagtail a11y checker. .card:nth-child(1) > .card__header

@phette23 phette23 added a11y accessibility frontend bug labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant