Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts with 2 keys block shortcuts with three #362

Open
kvendrik opened this issue Sep 26, 2016 · 4 comments
Open

Shortcuts with 2 keys block shortcuts with three #362

kvendrik opened this issue Sep 26, 2016 · 4 comments

Comments

@kvendrik
Copy link

Say you have a shortcut for g s and one for g s p. g s p won't work as the library triggers the callback as soon as it gets to g s and then resets. I tested this with the latest version (1.6.0) and tried older versions down to 1.4.2 but the result was the same.

http://codepen.io/anon/pen/rrmyAY?editors=0010

@juanparadox
Copy link

I resolved this issue by going the keyCode route with vanilla JS. Would be helpful if someone could update the code to prevent the issue you stated...

@kvendrik
Copy link
Author

kvendrik commented Mar 9, 2017

@juanparadox you might wanna check out https://github.com/shopify/hotshot to use until Mousetrap has implemented a fix.

@ntoscomeli
Copy link

@juanparadox could you specify in code how you resolve this issue? Maybe a demo. Thanks in advance

@juanparadox
Copy link

@ntoscomeli I basically just captured the keystrokes using key event listeners and debouncing the clicks. Unfortunately, I don't have a demo and apologies for replying so late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants