Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relying on cargo metadata rather than individual Manifest files #5

Open
jelmansouri opened this issue Jun 3, 2022 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@jelmansouri
Copy link

First thanks a lot for putting up a Visual Studio extension that works with RustAnalyser ! I was wondering if there is any reason why you are not relying on cargo metadata output to list the targets, find the target directory and such.
I can do a change in that regard if you are willing to review and in case there is rationale for that.

@cchharris
Copy link
Owner

Thanks for the interest! I did investigate cargo metadata - if I recall correctly, it didn't give all the information I needed to fully setup certain VS Integrations, like Build or Build+Run.

I'll give this a second look when I get a chance, as not having to parse the TOML ourselves and getting cargo's own interpretation would be very nice, and prevent us from deviating.

@cchharris cchharris added the enhancement New feature or request label Jun 5, 2022
@cchharris
Copy link
Owner

cchharris commented Aug 11, 2022

Apologies for the delay on getting to this - I recently switched jobs and have been onboarding and otherwise occupied.

I recently saw Rust update Cargo to support showing test binaries location via cmd line - here.

I'll look into shifting grabbing as much information as possible from the existing cargo commands now, rather than rolling our own Toml. I'll probably be able to start working on that come next week.

(Edit) Apparently that was even earlier this year before this issue was even made. Regardless, I just now became aware of it, so I'll see if I can't incorporate it 😄

@cchharris
Copy link
Owner

Just investigated this. I'm refreshing my memory of what information is necessary for the Visual Studio plugin, but it seems like this is a viable alternative to parsing the Toml ourselves. Will see if I can't get a proof of concept going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants