Merge pull request #25 from ccremer/hooks

Change pipeline hook type to plain func instead of interface

Author: ccremer

examples/hooks_test.go

@@ -10,15 +10,11 @@ import (
 	pipeline "github.com/ccremer/go-command-pipeline"
 )
 
-type PipelineLogger struct{}
-
-func (l *PipelineLogger) Accept(step pipeline.Step) {
-	fmt.Println(fmt.Sprintf("Executing step: %s", step.Name))
-}
-
 func TestExample_Hooks(t *testing.T) {
 	p := pipeline.NewPipeline()
-	p.AddBeforeHook(&PipelineLogger{})
+	p.AddBeforeHook(func(step pipeline.Step) {
+		fmt.Println(fmt.Sprintf("Executing step: %s", step.Name))
+	})
 	p.WithSteps(
 		pipeline.NewStep("hook demo", AfterHookAction()),
 	)

pipeline.go

@@ -38,11 +38,8 @@ type (
 	}
 	// Context contains arbitrary data relevant for the pipeline execution.
 	Context interface{}
-	// Listener is a simple interface that listens to Pipeline events.
-	Listener interface {
-		// Accept takes the given Step.
-		Accept(step Step)
-	}
+	// Listener is a simple func that listens to Pipeline events.
+	Listener func(step Step)
 	// ActionFunc is the func that contains your business logic.
 	// The context is a user-defined arbitrary data of type interface{} that gets provided in every Step, but may be nil if not set.
 	ActionFunc func(ctx Context) Result
@@ -132,8 +129,8 @@ func (p *Pipeline) Run() Result {
 
 func (p *Pipeline) doRun() Result {
 	for _, step := range p.steps {
-		for _, listener := range p.beforeHooks {
-			listener.Accept(step)
+		for _, hooks := range p.beforeHooks {
+			hooks(step)
 		}
 
 		result := step.F(p.context)

pipeline_test.go

@@ -42,7 +42,7 @@ func TestPipeline_Run(t *testing.T) {
 					return Result{}
 				}),
 			},
-			givenBeforeHook: hook,
+			givenBeforeHook: hook.Accept,
 			expectedCalls:   2,
 		},
 		"GivenPipelineWithFinalizer_WhenRunning_ThenCallHandler": {