Eigth pass at enabling PMD.

Author: dancc

src/main/java/com/cdancy/bitbucket/rest/domain/activities/Activities.java

@@ -81,22 +81,22 @@ public enum ActivitiesType {
     public abstract List<User> removedReviewers();
 
     @SerializedNames({"id", "createdDate", "user", "action", "commentAction", 
-        "comment", "fromHash", "previousFromHash", "previousToHash",
-        "toHash", "added", "removed", "addedReviewers", "removedReviewers"})
+            "comment", "fromHash", "previousFromHash", "previousToHash",
+            "toHash", "added", "removed", "addedReviewers", "removedReviewers"})
     public static Activities create(final long id, 
             final long createdDate, 
             final User user, 
             final ActivitiesType action, 
             final String commentAction, 
             final Comments comment, 
-            final @Nullable String fromHash,
-            final @Nullable String previousFromHash,  
-            final @Nullable String previousToHash,
-            final @Nullable String toHash, 
-            final @Nullable ActivitiesCommit added,
-            final @Nullable ActivitiesCommit removed, 
-            final @Nullable List<User> addedReviewers,
-            final @Nullable List<User> removedReviewers) {
+            @Nullable final String fromHash,
+            @Nullable final String previousFromHash,  
+            @Nullable final String previousToHash,
+            @Nullable final String toHash, 
+            @Nullable final ActivitiesCommit added,
+            @Nullable final ActivitiesCommit removed, 
+            @Nullable final List<User> addedReviewers,
+            @Nullable final List<User> removedReviewers) {
 
         return new AutoValue_Activities(id, 
                 createdDate, 

src/main/java/com/cdancy/bitbucket/rest/domain/branch/BranchRestriction.java

@@ -58,7 +58,7 @@ public static BranchRestriction create(final Long id,
             final Matcher matcher,
             final List<User> users, 
             final List<String> groups, 
-            final @Nullable List<AccessKey> accessKeys) {
+            @Nullable final List<AccessKey> accessKeys) {
 
         final List<Long> accessKeyId = new ArrayList<>();
         if (accessKeys != null) {

src/main/java/com/cdancy/bitbucket/rest/domain/branch/BranchRestrictionPage.java

@@ -31,14 +31,14 @@
 public abstract class BranchRestrictionPage implements Page<BranchRestriction>, ErrorsHolder {
 
     @SerializedNames({ "start", "limit", "size", 
-        "nextPageStart", "isLastPage", "values", "errors" })
+            "nextPageStart", "isLastPage", "values", "errors" })
     public static BranchRestrictionPage create(final int start, 
             final int limit, 
             final int size, 
             final int nextPageStart, 
             final boolean isLastPage,
-            final @Nullable List<BranchRestriction> values, 
-            final @Nullable List<Error> errors) {
+            @Nullable final List<BranchRestriction> values, 
+            @Nullable final List<Error> errors) {
 
         return new AutoValue_BranchRestrictionPage(start, 
                 limit, 

src/main/java/com/cdancy/bitbucket/rest/domain/comment/MinimalAnchor.java

@@ -28,7 +28,7 @@ public abstract class MinimalAnchor {
     public abstract String type();
 
     @SerializedNames({ "id", "type" })
-    public static MinimalAnchor create(int id, String type) {
+    public static MinimalAnchor create(final int id, final String type) {
         return new AutoValue_MinimalAnchor(id, type);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/comment/PermittedOperations.java

@@ -33,9 +33,9 @@ public abstract class PermittedOperations {
     }
 
     @SerializedNames({ "editable", "deletable", "transitionable" })
-    public static PermittedOperations create(boolean editable, 
-            boolean deletable, 
-            boolean transitionable) {
+    public static PermittedOperations create(final boolean editable, 
+            final boolean deletable, 
+            final boolean transitionable) {
         return new AutoValue_PermittedOperations(editable, deletable, transitionable);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/comment/Task.java

@@ -55,10 +55,22 @@ public abstract class Task implements ErrorsHolder {
 
     @SerializedNames({ "anchor", "author", "createdDate", "id", "text",
             "state", "permittedOperations", "errors" })
-    public static Task create(TaskAnchor anchor, Author author, 
-            long createdDate, int id, String text, 
-            String state, PermittedOperations permittedOperations, List<Error> errors) {
-        return new AutoValue_Task(Utils.nullToEmpty(errors), anchor, author, createdDate, 
-                id, text, state, permittedOperations);
+    public static Task create(final TaskAnchor anchor, 
+            final Author author, 
+            final long createdDate, 
+            final int id, 
+            final String text, 
+            final String state, 
+            final PermittedOperations permittedOperations, 
+            final List<Error> errors) {
+        
+        return new AutoValue_Task(Utils.nullToEmpty(errors), 
+                anchor, 
+                author, 
+                createdDate, 
+                id, 
+                text, 
+                state, 
+                permittedOperations);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/comment/TaskAnchor.java

@@ -53,10 +53,24 @@ public abstract class TaskAnchor {
 
     @SerializedNames({ "properties", "id", "version", "text", 
             "author", "createdDate", "updatedDate", "permittedOperations", "type" })
-    public static TaskAnchor create(Map<String, String> properties, int id, int version, String text, 
-            Author author, long createdDate, long updatedDate, 
-            PermittedOperations permittedOperations, String type) {
-        return new AutoValue_TaskAnchor(Utils.nullToEmpty(properties), id, version, text, 
-                author, createdDate, updatedDate, permittedOperations, type);
+    public static TaskAnchor create(final Map<String, String> properties, 
+            final int id, 
+            final int version, 
+            final String text, 
+            final Author author, 
+            final long createdDate, 
+            final long updatedDate, 
+            final PermittedOperations permittedOperations, 
+            final String type) {
+        
+        return new AutoValue_TaskAnchor(Utils.nullToEmpty(properties), 
+                id, 
+                version, 
+                text, 
+                author, 
+                createdDate, 
+                updatedDate, 
+                permittedOperations, 
+                type);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/common/RequestStatus.java

@@ -37,7 +37,10 @@
 public abstract class RequestStatus implements Value<Boolean>, ErrorsHolder {
 
     @SerializedNames({ "value", "errors" })
-    public static RequestStatus create(@Nullable Boolean value, List<Error> errors) {
-        return new AutoValue_RequestStatus(value, Utils.nullToEmpty(errors));
+    public static RequestStatus create(@Nullable final Boolean value, 
+            final List<Error> errors) {
+        
+        return new AutoValue_RequestStatus(value, 
+                Utils.nullToEmpty(errors));
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/defaultreviewers/Condition.java

@@ -49,11 +49,22 @@ public abstract class Condition implements ErrorsHolder {
     @Nullable
     public abstract Long requiredApprovals();
 
-    @SerializedNames({ "id", "scope", "sourceRefMatcher", "targetRefMatcher", "reviewers", "requiredApprovals", "errors"})
-    public static Condition create(Long id, Scope scope, Matcher sourceRefMatcher,
-                                   Matcher targetRefMatcher, List<User> reviewers, Long requiredApprovals,
-                                   @Nullable List<Error> errors) {
-        return new AutoValue_Condition(Utils.nullToEmpty(errors), id, scope, sourceRefMatcher, targetRefMatcher,
-            reviewers, requiredApprovals);
+    @SerializedNames({ "id", "scope", "sourceRefMatcher", 
+            "targetRefMatcher", "reviewers", "requiredApprovals", "errors"})
+    public static Condition create(final Long id, 
+            final Scope scope, 
+            final Matcher sourceRefMatcher,
+            final Matcher targetRefMatcher, 
+            final List<User> reviewers, 
+            final Long requiredApprovals,
+            @Nullable final List<Error> errors) {
+        
+        return new AutoValue_Condition(Utils.nullToEmpty(errors), 
+                id, 
+                scope, 
+                sourceRefMatcher, 
+                targetRefMatcher,
+                reviewers, 
+                requiredApprovals);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/defaultreviewers/Scope.java

@@ -33,7 +33,7 @@ public enum ScopeType {
     public abstract Long resourceId();
 
     @SerializedNames({ "type", "resourceId"})
-    public static Scope create(ScopeType type, Long resourceId) {
+    public static Scope create(final ScopeType type, final Long resourceId) {
         return new AutoValue_Scope(type, resourceId);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/file/Blame.java

@@ -49,11 +49,24 @@ public abstract class Blame {
     @SerializedNames({ "author", "authorTimestamp", "commitHash", 
             "displayCommitHash", "commitId", "commitDisplayId", 
             "fileName", "lineNumber", "spannedLines" })
-    public static Blame create(Author author, String authorTimestamp, String commitHash, 
-            String displayCommitHash, String commitId, String commitDisplayId, 
-            String fileName, int lineNumber, int spannedLines) {
-        return new AutoValue_Blame(author, authorTimestamp, commitHash, 
-                displayCommitHash, commitId, commitDisplayId, 
-                fileName, lineNumber, spannedLines);
+    public static Blame create(final Author author, 
+            final String authorTimestamp, 
+            final String commitHash, 
+            final String displayCommitHash, 
+            final String commitId, 
+            final String commitDisplayId, 
+            final String fileName, 
+            final int lineNumber, 
+            final int spannedLines) {
+        
+        return new AutoValue_Blame(author, 
+                authorTimestamp, 
+                commitHash, 
+                displayCommitHash, 
+                commitId, 
+                commitDisplayId, 
+                fileName, 
+                lineNumber, 
+                spannedLines);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/file/Line.java

@@ -35,7 +35,7 @@ public abstract class Line {
     }
 
     @SerializedNames({ "text", "type" })
-    public static Line create(String text, String type) {
+    public static Line create(final String text, final String type) {
         return new AutoValue_Line(text, type);
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/file/LinePage.java

@@ -34,11 +34,24 @@ public abstract class LinePage implements Page<Line>, ErrorsHolder {
     @Nullable
     public abstract List<Blame> blame();
 
-    @SerializedNames({ "start", "limit", "size", "nextPageStart", "isLastPage", "lines", "blame", "errors" })
-    public static LinePage create(int start, int limit, int size, int nextPageStart, 
-            boolean isLastPage,@Nullable List<Line> lines, 
-            @Nullable List<Blame> blame, @Nullable List<Error> errors) {
-        return new AutoValue_LinePage(start, limit, size, nextPageStart, isLastPage,
-                Utils.nullToEmpty(lines), Utils.nullToEmpty(errors), Utils.nullToEmpty(blame));
+    @SerializedNames({ "start", "limit", "size", "nextPageStart", 
+            "isLastPage", "lines", "blame", "errors" })
+    public static LinePage create(final int start, 
+            final int limit, 
+            final int size, 
+            final int nextPageStart, 
+            final boolean isLastPage, 
+            @Nullable final List<Line> lines, 
+            @Nullable final List<Blame> blame, 
+            @Nullable final List<Error> errors) {
+        
+        return new AutoValue_LinePage(start, 
+                limit, 
+                size, 
+                nextPageStart, 
+                isLastPage,
+                Utils.nullToEmpty(lines), 
+                Utils.nullToEmpty(errors), 
+                Utils.nullToEmpty(blame));
     }
 }

src/main/java/com/cdancy/bitbucket/rest/domain/file/RawContent.java

@@ -32,7 +32,10 @@
 public abstract class RawContent implements Value<String>, ErrorsHolder {
 
     @SerializedNames({ "value", "errors" })
-    public static RawContent create(@Nullable String value, List<Error> errors) {
-        return new AutoValue_RawContent(value, Utils.nullToEmpty(errors));
+    public static RawContent create(@Nullable final String value, 
+            final List<Error> errors) {
+        
+        return new AutoValue_RawContent(value, 
+                Utils.nullToEmpty(errors));
     }
 }