Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not added in spec/examples #212

Closed
rjalander opened this issue May 8, 2024 · 3 comments · Fixed by #230
Closed

Links not added in spec/examples #212

rjalander opened this issue May 8, 2024 · 3 comments · Fixed by #230
Assignees

Comments

@rjalander
Copy link

Links are not created for any of the spec/examples, but they have schemaUri and chain_id, it's good to have links too for validation.

@afrittoli
Copy link
Contributor

Thanks @rjalander - we are aware of this, @xibz planned examples to be added as a follow-up.

@afrittoli
Copy link
Contributor

Perhaps we could add at least empty link lists to all examples links: [] which will help trigger better validation.

@afrittoli
Copy link
Contributor

We discussed this with @xibz today. Having links in the examples is very beneficial for validation, but confusing for end-users because examples are not associated with a specific use case and thus those links are not meaningful.

To solve the issue, I will rename examples to conformance, and add the links to the JSON files in there.
We'll then build over time a proper set of examples. See more details in #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants