Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters are only ran on main #224

Closed
xibz opened this issue May 13, 2024 · 2 comments
Closed

Linters are only ran on main #224

xibz opened this issue May 13, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@xibz
Copy link
Contributor

xibz commented May 13, 2024

With all the efforts being put into linters and cherry picking them to other branches, I noticed that none of them were being ran.

#223

While it isn't too big of a deal not having any linting on the cherry pick branches, but since it's easy enough to turn on and will ensure consistency between the pick branches vs main, I would opt to turn them on.

@xibz
Copy link
Contributor Author

xibz commented May 13, 2024

#221 fixes this

@afrittoli afrittoli self-assigned this May 13, 2024
@afrittoli afrittoli added the ci label May 13, 2024
@afrittoli afrittoli added this to the v0.5 milestone May 13, 2024
@afrittoli
Copy link
Contributor

On the spec-v0.4 branch this is fixed by #220

@xibz xibz closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants