Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestoreHist Warning on switching #185

Closed
emyoulation opened this issue Jun 2, 2022 · 2 comments
Closed

RestoreHist Warning on switching #185

emyoulation opened this issue Jun 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@emyoulation
Copy link

After just loading the Example.tree (swapping out my 45,000 person tree), I was switching via views the Navigator bar: from the Relationships standard view mode to the People Person CardView mode. Perhaps it was passing a bad signal?

The following Warning went to the Console (not the GUI)

Warning: GlobalHistory: Signal emitted with wrong arg types: active-changed
         from: file: C:\Users\DistrictSupport\AppData\Roaming\gramps\gramps51\plugins\RestoreHist\restorehist.py
               line: 59
               func: clear_history
    arg passed was: ['Person', 'GNUJQCL9MD64AM56OH'], type of arg passed <class 'list'>,  type should be: <class 'tuple'>
render_page: I0000044 5.375149965286255
@cdhorn
Copy link
Owner

cdhorn commented Jun 2, 2022

Yes, the RestoreHist add on does not preserve the tuple for the new navigation class as json.dumps converts to a list and it gets read back in as a list. This can safely be ignored.

I am going to submit a patch for Paul for it when I get around to it, so I guess I'll leave this open as a reminder till I do.

@cdhorn cdhorn changed the title Warning on switching RestoreHist Warning on switching Jun 2, 2022
@cdhorn cdhorn added the bug Something isn't working label Jun 2, 2022
@cdhorn
Copy link
Owner

cdhorn commented Jun 7, 2022

Going to close this one. I opened gramps-project/addons-source#540 against RestoreHist plugin for it.

@cdhorn cdhorn closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants