Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person and Relationships Citations omitted #230

Open
emyoulation opened this issue Nov 18, 2022 · 1 comment
Open

Person and Relationships Citations omitted #230

emyoulation opened this issue Nov 18, 2022 · 1 comment

Comments

@emyoulation
Copy link

emyoulation commented Nov 18, 2022

The Person CardView Citations panels omitted Event citations (where the Person was 'Primary' role and another where they were 'Witness' role), including Family Events where the Person was a Spouse.

The Relationships CardView omitted the same but also omitted other citations related to data all the People, Families and Events shown in the View mode. It seems like the Relationship should list all Citations for any object represented in the View.
image

A zipped tiny _YodaCitations_2022-11-18.gramps sample file with various Citations is attached. This allows the Citation category View to be used as a sanity check.

_GrampsCitationsTest.zip
image

@cdhorn
Copy link
Owner

cdhorn commented Dec 10, 2022

Yes it could be extended to show all citations relevant to the person. Something similar could be done for families.

I find showing event citations for non-primary roles to be problematic. In my mind the event reference should hold the citations regarding the role the person played in the event, not the event record itself as there is no way to know which citations on the event pertain to which participants. Hence the PR I submitted for consideration for 5.2 that added CitationBase to the EventRef object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants