Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gramps 5.2 testing #239

Open
TheMihle opened this issue Feb 24, 2024 · 5 comments
Open

Gramps 5.2 testing #239

TheMihle opened this issue Feb 24, 2024 · 5 comments

Comments

@TheMihle
Copy link

TheMihle commented Feb 24, 2024

For fun I wanted to see if this plugin would work on Gramps 5.2 without any changes. So I tried to install it, and go in to the files where I found reference to "5.1" (.gpr.py files) and change them to 5.2.

The plugin seem to be working mostly fine from what I have seen until now, but there is two things I have noticed:

  1. The columns doest seem to auto expand to fill the width anymore.
  2. Tags view works fine in Card view, but in standard "Tags" view it creates an error, not sure its related to this mod or not. I may further test with disabling the plugin to see.
@TheMihle TheMihle changed the title Gramps 5.2 testing issues Gramps 5.2 testing Feb 24, 2024
@emyoulation
Copy link

emyoulation commented Mar 6, 2024

I vaguely recall a bug report. There was another view (or dialog table) that had a similar problem. It seemed to be related to the the way 5.2 preferences started saving resized columns instead of re-initializing to defaults.

There was a problem if the width of the rightmost was always simply loaded from preferences. Instead it needed to take the greater of: that value or the calculated remainder of the windows width.

@AnneLaureF
Copy link

I also tried it, changing the gramps target version to 5.2 in all the .gpr.py files.
It mostly works (the exceptions I sometimes get happened in 5.1 already)

Here is a very basic patch so that the tagview doesn't crash anymore:

diff --git a/src/tagview.py b/src/tagview.py
index b71e4f8..f127f39 100644
--- a/src/tagview.py
+++ b/src/tagview.py
@@ -225,6 +225,9 @@ class TagView(ListView):
         """
         return None
 
+    def get_config_name(self):
+        return __name__
+
     def get_stock(self):
         """
         Use the gramps-tag stock icon

@cdhorn
Copy link
Owner

cdhorn commented Apr 24, 2024

Switched tip of master over to 5.2. Thanks @AnneLaureF I included that as well.

@cdhorn
Copy link
Owner

cdhorn commented Apr 24, 2024

@TheMihle what OS are you running on as I'm not seeing that on Fedora at least at first glance?

@TheMihle
Copy link
Author

TheMihle commented Jun 12, 2024

@TheMihle what OS are you running on as I'm not seeing that on Fedora at least at first glance?

@cdhorn I didnt see this before now, sorry.

I am on windows. I installed your updated version.
If you are talking about the not auto expanding thing, Here is some screenshots:
In 5.2 it looks like this:
image
in 5.1.5 it looked like this:
image

Aka its not auto width anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants