-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance SchemaObject type for composition types #697
Conversation
- Composition types: allOf, anyOf, oneOf and not are valid SchemaObjects
Hey @cdimascio! First of all thanks for all your work here! We use |
Hey @cdimascio: Could you find the time to have a quick look at this change? It's just typing level with no runtime code change and would spare typescript users a lot of insecure and redundant type assertions. |
Hey @cdimascio! I updated my branch, status checks pass. Is there anything else I can do? |
Hey @cdimascio, any thoughts about this? |
Hey @cdimascio: New year next try! ;) |
Will roll a new version soon |
available in v.5.0.1 |
Thanks a lot! This fixes quite some cases where we had to "unknown-assert" parts of the schema before! :) |
Composition types (allOf, anyOf, oneOf and not) are valid SchemaObjects according to the spec, but right now anything without type could not be assigned as a schema.