Add multipart fix when does not exist any body #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiuxmaycry
commented
Feb 19, 2024
| @@ -13,19 +13,22 @@ export async function createApp( | |||
| port = 3000, | |||
| customRoutes = (app) => {}, | |||
| useRoutes = true, | |||
| apiRouter = undefined, | |||
There was a problem hiding this comment.
Parameter was not used
hiuxmaycry
commented
Feb 19, 2024
| @@ -216,7 +220,6 @@ export class RequestValidator { | |||
| } | |||
| } | |||
| }); | |||
| return null; | |||
There was a problem hiding this comment.
redundant return 🙂
There was a problem hiding this comment.
function return it is not used
|
Hi @cdimascio, can you please review this? 🙂 |
cdimascio
approved these changes
Feb 21, 2024
|
Hi @cdimascio sorry for the inconvenience, do we have an ETA on when this fix will be released? |
|
Hey @cdimascio, any chance you have an ETA for when this fix will be released? Thanks! |
This was referenced Jun 24, 2024
This was referenced Aug 26, 2024
This was referenced Sep 13, 2024
This was referenced Sep 15, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context in our project we have endpoints in which there is no type of body parser involved, so req.body is always undefined for those requests. This happens because the body is not consumed on the server but is simply forwarded to another API (Our API is just a proxy to another API).
Therefore, we do not validate the content of the file in any way, we only check that the endpoint exists in the SPEC.
That said, we validate that the
multipartNestedfunction is only applied when the body exists so as not to generate an error ofTypeError: Cannot convert undefined or null to object.