-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD versioning should be consistent. v1beta1, v1alpha1, v1 etc #1962
CRD versioning should be consistent. v1beta1, v1alpha1, v1 etc #1962
Comments
@shinebayar-g thanks for reporting this. I agree that we should be version suffixing everything, the problem is that would be a breaking change, which we decided to avoid for now. We thought it makes sense for the non suffixed class (i.e main class) to be the most stable version (not necessarily that latest) of the class. This is why we prefer We'll look into it. Thanks! |
Yeah I agree on the breaking change part. When there are only |
Yeah, we might consider a new major version if we have additional pressing issues that require a breaking change. (please share if you know of any such issues) |
…m/cdk8s#1962 Signed-off-by: Shinebayar Gansukh <3091558+shinebayar-g@users.noreply.github.com>
…m/cdk8s#1962 Signed-off-by: Shinebayar Gansukh <3091558+shinebayar-g@users.noreply.github.com>
Description of the bug:
When using
cdk8s import
, if there are multiple versions of the CRD likev1alpha1
&v1beta1
, cdk8s uses v1alpha1 for main class name. Because of this, a lot of users are unknowingly using the v1alpha1 resource besides there is a newer version available.Reproduction Steps:
In this example,
cdk8s generates 2 different versions for
ExternalSecret
CRD. Howeverv1alpha1
becomes the main class.Or in this example, cdk8s generates
In this case v1 class is the main class, much better.
There are other cases where it gets inconsistent. For example, when there are
v1
andv2
CRDs,v1
becomes the main class andv2
gets prefix likeSomethingv2
. However if there arev2
andv3
CRDs,v2
CRD becomes main class with no prefix.Error Log:
Environment:
"cdk8s-cli": "2.198.105", "cdk8s": "^2.68.69",
Other:
Perhaps cdk8s can follow Terraform k8s provider's approach to version everything and remove unversioned class names.
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: