fix: stager fails when the file to download doesn't exist #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2023 13:10
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
rix0rrr
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the stager function receives a message to download a file that should exist but doesn' t. If we throw an error, the message will be sent to the DLQ, to be processed again in a re-drive. But given that this file will probably never be available, the re-drives will also fail, and we'll never be able to get rid of the message in the DLQ. Instead, we ignore this version by returning silently.
NPM seems to occasionally drop tarballs on the floor when a new package version is released, which you can notice on the download stats because the package has been downloaded
0times. So far we've seen that happen for:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license