Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working without a logger specified #3

Open
Fxlr8 opened this issue Mar 31, 2018 · 4 comments
Open

not working without a logger specified #3

Fxlr8 opened this issue Mar 31, 2018 · 4 comments

Comments

@Fxlr8
Copy link

Fxlr8 commented Mar 31, 2018

This is not working

import { NatsPubSub } from 'graphql-nats-subscriptions'
const pubsub = new NatsPubSub()

Here is the error

TypeError: Cannot read property 'child' of undefined
    at new NatsPubSub (...blah/node_modules/graphql-nats-subscriptions/src/nats-pubsub.ts:52:38)
    at Object.<anonymous> (...blah/.build/webpack:/src/pubsub.js:3:16)

Is the logger required?

import * as Logger from 'bunyan';

Why then it is not listed in dependencies?
"dependencies": {
"graphql-subscriptions": "^0.5.6",
"lodash": "^4.17.4",
"nats": "^0.7.20"
},

@matheuscampanhaf
Copy link

Any updates on that ?

@veeramarni
Copy link
Collaborator

The logger is still needed. You can use pino logger or some other logger. I would like to remove that dependency but I have no time to make that change. If you can create PR, I can review it.

@greg-md
Copy link

greg-md commented Mar 3, 2021

Still not fixed?

@gedw99
Copy link

gedw99 commented Oct 20, 2021

@veeramarni why not add an example showing the js and nats system working ?

it would make it much easier for me and others to get past these initial getting started bugs and likely to get more participation and eventually PR’s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants