Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate CAS as found in SweetFX feasible to avoid RCAS artifacts? #32

Closed
aufkrawall opened this issue Aug 2, 2024 · 14 comments
Closed

Comments

@aufkrawall
Copy link

When applying RCAS with high strength, it can cause weird artifacts (as described in Config.md). The CAS shader in ReShade SweetFX can apply quite strong sharpen with e.g. a strength of 2.0, but doesn't seem to have this issue. Which is why I wonder if applying CAS like that could be feasible inside OptiScaler too?

@cdozdil
Copy link
Owner

cdozdil commented Aug 2, 2024

Hi,

Funny thing is we started with CAS, because of these artifacts I have adapted RCAS (which prevented these issues.

Need to update issues page 😊

@aufkrawall
Copy link
Author

aufkrawall commented Aug 2, 2024

With high RCAS sharpen strength, I'm getting weird bright image areas:

witcher3_2024_08_02_12_13_57_446

Seems to be more distinct with FSR 3.1 than with XeSS. This doesn't occur with the SweetFX shader via ReShade.

@cdozdil
Copy link
Owner

cdozdil commented Aug 2, 2024

I have used this shader as referance, could you check if it's producing similar issues?

https://github.com/RdenBlaauwen/RCAS-for-ReShade/blob/main/RCAS.fx

@aufkrawall
Copy link
Author

The issue does not occur with that RCAS shader used in ReShade.

@cdozdil
Copy link
Owner

cdozdil commented Aug 2, 2024

Hi,

Could you try this build?

nvngx.zip

@aufkrawall
Copy link
Author

It doesn't seem to occur with this build, but the sharpen effectiveness of RCAS also seems to be reduced to (almost?) non-existent.

@cdozdil
Copy link
Owner

cdozdil commented Aug 3, 2024

Hi,

I just checked on some games on my notebook, RCAS seems to be working?

@aufkrawall
Copy link
Author

Yeah, however with that new build, it looks way softer than RCAS via ReShade at the same strength:

witcher3_2024_08_03_10_36_03_447

witcher3_2024_08_03_10_36_26_858

@cdozdil
Copy link
Owner

cdozdil commented Aug 3, 2024

Hi,

Thanks for pointing this out, I found a mistake on my shader code (multiplied with denoise value twice).
Could you check if this build fixes the issue?

nvngx.zip

@aufkrawall
Copy link
Author

aufkrawall commented Aug 3, 2024

Thanks! They are closer to each other now (I also forgot to re-enable the denoiser in the ReShade shader for the previous screenshots...), but I think ReShade is still a tad sharper?

witcher3_2024_08_03_16_36_21_731

witcher3_2024_08_03_16_37_22_772

The ReShade shader also allows to enter a sharpen strength of up to 1.3 (I used 1.0 though), maybe that would be the cheapest way to get to higher sharpen strength in OptiScaler? 🐸 As FSR 3.1 also is quite soft.

@cdozdil
Copy link
Owner

cdozdil commented Aug 3, 2024

Yeah, that was in my mind too. I will check and adapt it later today 👍🏻

@cdozdil
Copy link
Owner

cdozdil commented Aug 3, 2024

Ok, prepared another test build.

nvngx.zip

@aufkrawall
Copy link
Author

Thanks, it definitely works now to get higher sharpen without the previous artifacts! :)
If I were nitpicky, I'd say the shader via ReShade still sharpens the image a bit more evenly. But you probably have far more exciting stuff on your agenda. Thanks again!

@cdozdil
Copy link
Owner

cdozdil commented Aug 4, 2024

Thanks for helping me to sort out this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants