Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dist-hyrdate-app output #524

Merged
merged 1 commit into from
May 13, 2024
Merged

feat: Add dist-hyrdate-app output #524

merged 1 commit into from
May 13, 2024

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented May 10, 2024

Summary | Résumé

Add the dist-hydrate-script output to web components package. This will allow developers the tools to be able to render the Stencil web components on the server side in different frameworks available from @cdssnc/gcds-components/hydrate.

@ethanWallace ethanWallace changed the title feat: Add dist-hyrdate-app output target feat: Add dist-hyrdate-app output May 10, 2024
Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to have in our web components package -- we'll have to update our documentation so people are aware of it but there's no rush for now.

Stencil has this documentation on how to use this so we can also just refer to that page.

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace merged commit c448c59 into main May 13, 2024
3 checks passed
@ethanWallace ethanWallace deleted the feat/hydrate-script branch May 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants