refactor: remove tokens redundant after CSS rewrite #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need a touchpoint with Design before merging this PR. |
…eading, and gcds-text into existing components (#231) * remove redundant tokens after integrating gcds-link into gcds-lang-toggle * refactor: remove redundant tokens after integrating gcds-link into gcds-card * refactor: remove redundant tokens after integrating gcds-link into gcds-breadcrumbs * refactor: remove redundant tokens after integrating gcds-link into gcds-footer * fix: revert removing footer-main-text token * refactor: remove redundant tokens after integrating setting regular size for gcds-link component in existing components * refactor: remove redundant tokens after integrating gcds-text and gcds-heading into existing components (#232) * refactor: remove redundant tokens after integrating gcds-text into gcds-card * refactor: remove redundant tokens after integrating gcds-text into gcds-card * refactor: remove redundant tokens after integrating gcds-text into gcds-error-message * refactor: remove redundant tokens after integrating gcds-text into gcds-hint * refactor: remove redundant tokens after integrating gcds-text into gcds-date-modified * chore: revert accidentally updated dates * refactor: remove redundant tokens after integrating gcds-heading into gcds-stepper * refactor: remove redundant tokens after integrating gcds-heading into gcds-error-summary
* refactor: keep red error colour for error summary links * refactor: revert red error colour for error summary links
melaniebmn
force-pushed
the
update-lang-toggle-padding
branch
from
95d708a to
e2857e1
Compare
|
@ethanWallace can you confirm that we won't be using the |
daine
previously approved these changes
Jul 10, 2024
I can confirm that token is no longer being used. |
|
@ethanWallace @daine I removed the unused card token, PR should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
As part of the CSS rewrite some of the tokens have become redundant.
gcds-linkwas integrated into the following components:gcds-breadcrumbsgcds-cardgcds-footergcds-lang-togglegcds-textwas integrated into the following components:gcds-cardgcds-date-modifiedgcds-error-messagegcds-hintgcds-headingwas integrated into the following components:gcds-error-summarygcds-stepperNote: This PR shouldn't be merged until the CSS rewrite changes are published and the component tokens in Figma are updated. I will keep it in draft mode for now.