Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize to submodule-per-toplevel-inductive-proof in Thm/Partial/Evaluation.lean #372

Open
1 of 2 tasks
cdisselkoen opened this issue Jun 24, 2024 · 0 comments
Open
1 of 2 tasks
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@cdisselkoen
Copy link
Contributor

Category

Lean formalization

Describe the feature you'd like to request

Each toplevel theorem in Thm/Partial/Evaluation.lean should live in its own submodule (potentially with its own submodules Binary.lean, GetAttr.lean, etc). This allows some of these proofs to cleanly use the toplevel results from other ("earlier") proofs, unlike the current design, where that is impossible due to circular imports, and results in e.g. the h_spetv workaround in #368 (grep the code for h_spetv, and see also this comment thread on #368).

Describe alternatives you've considered

The current design, where some toplevel results are passed directly as arguments to "later" proofs.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@cdisselkoen cdisselkoen added pending-review Awaiting review by the core team internal-improvement Refactoring, performance improvement, or other non-breaking change labels Jun 24, 2024
@john-h-kastner-aws john-h-kastner-aws added backlog and removed pending-review Awaiting review by the core team labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Development

No branches or pull requests

2 participants