Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help messages for errors related to the Cedar schemas #1125

Closed
1 of 2 tasks
shaobo-he-aws opened this issue Aug 8, 2024 · 1 comment
Closed
1 of 2 tasks

Add help messages for errors related to the Cedar schemas #1125

shaobo-he-aws opened this issue Aug 8, 2024 · 1 comment
Labels
papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request

Comments

@shaobo-he-aws
Copy link
Contributor

Describe the improvement you'd like to request

There currently do not exist help messages for errors like ToJsonSchemaError, or they are inlined in the error message. We should add them if possible or separate them from the error message text.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@shaobo-he-aws shaobo-he-aws added pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice backlog and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Aug 8, 2024
@shaobo-he-aws shaobo-he-aws mentioned this issue Aug 8, 2024
Closed
3 tasks
@shaobo-he-aws shaobo-he-aws linked a pull request Aug 8, 2024 that will close this issue
Add help messages to errors related to the Cedar schemas #1130
Closed
3 tasks
@john-h-kastner-aws john-h-kastner-aws added papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request and removed internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice backlog labels Oct 1, 2024
@shaobo-he-aws
Copy link
Contributor Author

Fixed by #1129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add help messages to errors related to the Cedar schemas cedar-policy/cedar
2 participants
@shaobo-he-aws @john-h-kastner-aws