Memory channel doesn't clear queues on close

[karolinepauls]

kombu/kombu/transport/memory.py

Line 59 in cbd327d

queue.empty()

queue.empty() doesn't empty the queue - it returns a boolean stating whether the queue is empty. In order to clear a queue (without touching the internals), one has to pop from it until it's empty.

It remains a question if clearing should take place at all and whether the queues should be channel-scoped or transport-scoped. There's definitely a need to be able to clear the queues between tests.

[auvipy]

failing test case with a fix?

[karolinepauls]

@auvipy There is no fix because I don't know what the expected behaviour is.

It remains a question if clearing should take place at all and whether the queues should be channel-scoped or transport-scoped. There's definitely a need to be able to clear the queues between tests.

It is crucial to decide on the behaviour wanted before commencing implementation.

[thedrow]

This is definitely a mistake.
Wouldn't setting self.queues to an empty dict be enough?

[karolinepauls]

The question remains - channel-scoped or transport-scoped? If it's answered, the fix is trivial.

[thedrow]

If you purge the queue using RabbitMQ, it is purged for all channels, right?