Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: clarify Q3 extended data #1454

Closed
rootulp opened this issue Mar 8, 2023 · 4 comments · Fixed by celestiaorg/rsmt2d#153
Closed

specs: clarify Q3 extended data #1454

rootulp opened this issue Mar 8, 2023 · 4 comments · Fixed by celestiaorg/rsmt2d#153
Assignees
Labels
specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Mar 8, 2023

Context

#1442 (comment)

Proposal

Confirm that it doesn't matter if Q3 is extended from Q1 or Q2. Then add a note to

Where `A -> B` indicates that `B` is computed using [erasure coding](#reed-solomon-erasure-coding) from `A`:
- `Q0 -> Q1` for each row in `Q0` and `Q1`
- `Q0 -> Q2` for each column in `Q0` and `Q2`
- `Q2 -> Q3` for each row in `Q2` and `Q3`

@rootulp rootulp added the specs directly relevant to the specs label Mar 8, 2023
@rootulp rootulp self-assigned this Mar 8, 2023
@evan-forbes evan-forbes added this to the Mainnet milestone Mar 8, 2023
@staheri14
Copy link
Collaborator

We may need to also update the link added as part of this PR #1461 if the extension logic is explained in a different section of the data structure spec.

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 10, 2023

Verified that Q3 is identical if it is extended vertically from Q1 or horizontally from Q2. See this commit and this test which continues to pass.

@staheri14
Copy link
Collaborator

staheri14 commented Mar 10, 2023

Verified that Q3 is identical if it is extended vertically from Q1 or horizontally from Q2. See this commit and this test which continues to pass.

Great! Do you think it would make sense to add a comment to the code indicating that either direction i.e., Q1->Q3 or Q2->Q3 would have the same result (in addition to the specs).

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 10, 2023

to add a comment to the code

I don't think it would hurt. Will add a comment to the code in rsmt2d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specs directly relevant to the specs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants