-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specs: clarify Q3 extended data #1454
Comments
We may need to also update the link added as part of this PR #1461 if the extension logic is explained in a different section of the data structure spec. |
Verified that Q3 is identical if it is extended vertically from Q1 or horizontally from Q2. See this commit and this test which continues to pass. |
Great! Do you think it would make sense to add a comment to the code indicating that either direction i.e., Q1->Q3 or Q2->Q3 would have the same result (in addition to the specs). |
I don't think it would hurt. Will add a comment to the code in rsmt2d. |
Context
#1442 (comment)
Proposal
Confirm that it doesn't matter if Q3 is extended from Q1 or Q2. Then add a note to
celestia-app/specs/src/specs/data_structures.md
Lines 387 to 391 in c09843d
The text was updated successfully, but these errors were encountered: