Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the EthAddress struct from QGB and use cosmos-sdk one instead #308

Closed
Tracked by #301
rach-id opened this issue Apr 14, 2022 · 0 comments
Closed
Tracked by #301

Remove the EthAddress struct from QGB and use cosmos-sdk one instead #308

rach-id opened this issue Apr 14, 2022 · 0 comments
Assignees
@rach-id

Comments

@rach-id
Copy link
Member

rach-id commented Apr 14, 2022

Currently, we have two similar EthAddress structs defined in the QGB module and also the cosmos-sdk module (in the current development branch that adds the Orchestrator/Relayer to the Validator struct: celestiaorg/cosmos-sdk#112 ). We should remove the one in the QGB and keep the one in cosmos-sdk.
@rach-id rach-id added the C: QGB label Apr 14, 2022
@rach-id rach-id moved this to TODO in Celestia Node Apr 14, 2022
@rach-id rach-id mentioned this issue Apr 14, 2022
Closed
90 tasks
@rach-id rach-id mentioned this issue May 9, 2022
Merged
@rach-id rach-id moved this from TODO to In Review in Celestia Node May 9, 2022
@rach-id rach-id self-assigned this May 9, 2022
@rach-id rach-id moved this from In Review to Done in Celestia Node May 10, 2022
@rach-id rach-id closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id