Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple keys within signer #3259

Closed
cmwaters opened this issue Apr 4, 2024 · 0 comments · Fixed by #3433
Closed

Support multiple keys within signer #3259

cmwaters opened this issue Apr 4, 2024 · 0 comments · Fixed by #3433
Assignees
Labels
priority:high optional label to track the relative priority of planned items WS: BestTxs Reliable and seamless transaction flow

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Apr 4, 2024

Summary

Kinda doesn't need one

Problem Definition

Currently, the signer can only be set with a single address that it uses to sign all the transactions. Some users may want to submit sdk.Msgs with different accounts. This is the case with Raas providers who may want a dedicated account per rollup.

Proposal

Each transaction has a concept of signers. What is needed is that the signer needs to be read from the transaction and then checked whether the keyring has it. If so we sign with that account. We still won't support transactions with multiple signers but this is a rare requirement. For PFBs the signer will need to be provided. It may be possible to do this as an optional argument (especially if we know that the keyring only has a single signer).

@cmwaters cmwaters added the enhancement New feature or request label Apr 4, 2024
@cmwaters cmwaters self-assigned this Apr 4, 2024
@cmwaters cmwaters added WS: BestTxs Reliable and seamless transaction flow and removed enhancement New feature or request labels Apr 23, 2024
@cmwaters cmwaters added the priority:high optional label to track the relative priority of planned items label Apr 23, 2024
@ninabarbakadze ninabarbakadze self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high optional label to track the relative priority of planned items WS: BestTxs Reliable and seamless transaction flow
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants