Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB relayer wait for transactions to be confirmed #356

Closed
Tracked by #301
rach-id opened this issue Apr 26, 2022 · 0 comments
Closed
Tracked by #301

QGB relayer wait for transactions to be confirmed #356

rach-id opened this issue Apr 26, 2022 · 0 comments
Assignees

Comments

@rach-id
Copy link
Member

rach-id commented Apr 26, 2022

In #354, we added a simple mechanism for the QGB MVP to wait for transaction confirmation.
However, we will need to have a better mechanism for QGB 1.0.

Proposition

We can have a generic method that takes a transaction hash and a number of confirmations. Then, it subscribes to an EVM endpoint and keeps listening for new blocks.
Once a block is received, it checks if the transaction is included or not.
Then, it waits for a certain number of confirmations before returning.
This would allow the QGB to send the right transactions and not send a lot of them for the same valset which will be eventually rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant