Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icahost.AllowMessages unmodifiable by governance #3837

Open
rootulp opened this issue Aug 30, 2024 · 3 comments
Open

Make icahost.AllowMessages unmodifiable by governance #3837

rootulp opened this issue Aug 30, 2024 · 3 comments
Labels
needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk nice to have item is not blocking or required.

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 30, 2024

Context

#3824

Problem

Arabica and Mocha have an incorrect ICA host param for AllowMessages because it is the default [*]. It should be an explicit allowlist.

Proposal

Make icahost.AllowMessages unmodifiable by governance. Hard-code it to the explicit allowlist defined in https://github.com/celestiaorg/CIPs/blob/main/cips/cip-14.md

@rootulp rootulp added the WS: V3 3️⃣ item is directly relevant to the v3 hardfork label Aug 30, 2024
@rootulp rootulp self-assigned this Aug 30, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 9, 2024

We may not want to do this if we frequently get requests from teams to update the list because making the param unmodifiable by governance means that the list can only be modified via app version upgrades.

@rootulp rootulp removed their assignment Sep 9, 2024
@rootulp rootulp modified the milestone: v3 Sep 9, 2024
@evan-forbes evan-forbes added nice to have item is not blocking or required. needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk labels Sep 13, 2024
@evan-forbes
Copy link
Member

evan-forbes commented Sep 13, 2024

per sync

it doesn't appear that pfbs can be submitted via ICA, therefore we don't need to block PFBs, and governance can be responsible for picking the values

if this changes, then we can reevaluate, until this is deprioritized

@evan-forbes evan-forbes removed the WS: V3 3️⃣ item is directly relevant to the v3 hardfork label Sep 13, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 13, 2024

Related: #3857 we can get more visibility on the error with PFBs if we bump ibc-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk nice to have item is not blocking or required.
Projects
None yet
Development

No branches or pull requests

2 participants