-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make icahost.AllowMessages
unmodifiable by governance
#3837
Comments
We may not want to do this if we frequently get requests from teams to update the list because making the param unmodifiable by governance means that the list can only be modified via app version upgrades. |
per sync it doesn't appear that pfbs can be submitted via ICA, therefore we don't need to block PFBs, and governance can be responsible for picking the values if this changes, then we can reevaluate, until this is deprioritized |
Related: #3857 we can get more visibility on the error with PFBs if we bump ibc-go |
Context
#3824
Problem
Arabica and Mocha have an incorrect ICA host param for AllowMessages because it is the default [*]. It should be an explicit allowlist.
Proposal
Make
icahost.AllowMessages
unmodifiable by governance. Hard-code it to the explicit allowlist defined in https://github.com/celestiaorg/CIPs/blob/main/cips/cip-14.mdThe text was updated successfully, but these errors were encountered: