Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB relayer relay more than 2/3 signatures and less than all of them correctly #628

Closed
4 tasks
Tracked by #301
rach-id opened this issue Aug 17, 2022 · 0 comments
Closed
4 tasks
Tracked by #301
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented Aug 17, 2022

Summary of Bug

Currently, in the QGB smart contract, we're checking whether the provided list of signatures has the same number of validators in the current valset:

https://github.com/celestiaorg/quantum-gravity-bridge/blob/37b613843c7a0681fe2a8ae82d3422e1f1cfb311/src/QuantumGravityBridge.sol#L272

However, the relayer currently only puts the signatures it finds if they're above the required threshold. Therefore, if the relayer found a majority of signatures, while the rest are missing, it will relay them and the contract will revert, while it shouldn't.
Thus, the implementation of the relayer should be updated to support this.

Version

79b83d8

Steps to Reproduce

  • Run the e2e tests with 4 validators and 4 orchestrators.
  • stop one of the orchestrators.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rach-id rach-id added bug Something isn't working good first issue Good for newcomers C: QGB labels Aug 17, 2022
@rach-id rach-id moved this to TODO in Celestia Node Aug 17, 2022
@rach-id rach-id self-assigned this Aug 17, 2022
@rach-id rach-id moved this from TODO to In Progress in Celestia Node Aug 17, 2022
@rach-id rach-id moved this from In Progress to Done in Celestia Node Aug 18, 2022
@rach-id rach-id closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant