-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QGB decide on keeping the history of attestations #683
Comments
oh shoot, totally forgot about this, good thinking!! Perhaps we could add them to This will likely depend on our slashing mechanism(s) as well #332 |
Agreed, do we need to specify this now, or we can leave it for later? |
imo we should leave this for later, as it seems likely blocked by our slashing mechanism. Which also means that the amount of pruning that we need to do is also blocked by our slashing strategy |
Sounds good, I will keep it as part of QGB 2.0 tracking issue. Thanks a lot for your help |
to update this, we have to decide if we want the whole QGB history bad enough to make it consensus critical. This would mean adding the attestation requests to the block data during prepare and process proposal. @sweexordious mind elaborating on the benefits of having this be consensus critical? per sync discussion
cc @adlerjohn |
Thoughts: The benefit of dumping the QGB state to block data and making it consensus critical will enable relayers to sync from genesis for any new QGB contract. The problem is, will we have the confirms available? Since, in the new v2 design (v3 is different), we're going for a P2P network to gossip the confirms. If we want to suppose that the confirms will be available, we will need to make assumptions like:
If not, then dumping the attestations to block data is meaningless. Since, we won't have access to the confirms on the P2P layer. However, since we're submiting the data to EVM chains, we may be able to recover the call data, and decode the confirms. Or, even without decoding them, just replaying the same payload to any other target EVM chain. If we assume the latter, then, even the attestations history doesn't matter. Since, redeploying the QGB to another chain will be just replaying the transaction history from another already-deployed QGB. Thus, the only assumption in this case is: a QGB has already been deployed to some EVM chain. |
yeah 💯 ! |
can we close this issue? cc @sweexordious |
sure, thanks a lot |
With the #657, the Valset/DataCommitment confirms will be kept as transactions. However, the attestations, i.e ValsetRequests and DataCommitmentRequests will be pruned. We can also think of a similar design for attestations and dump them in a block to preserve the whole QGB history.
The text was updated successfully, but these errors were encountered: