Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of BroadcastModeBlock #868

Open
evan-forbes opened this issue Oct 13, 2022 · 1 comment
Open

Remove usage of BroadcastModeBlock #868

evan-forbes opened this issue Oct 13, 2022 · 1 comment

Comments

@evan-forbes
Copy link
Member

    [question] should this be `flags.BroadcastMode` per https://github.com/cosmos/cosmos-sdk/blob/7781cdb3d20bc7ebac017452897ce1e6ab3903ef/client/flags/flags.go#L114
// should be submitted async, sync, or block (see flags.BroadcastMode). If

Note: block mode was removed in cosmos/cosmos-sdk#12659. Since celestia-app currently uses cosmos-sdk v0.46.0 we can still use block here but note to future selves that we'll need to remove it when we upgrade cosmos-sdk to a release with that change

Originally posted by @rootulp in #866 (comment)

blocking until a tx is included in a block is useful for testing purposes. Since its being deprecated, we need to create a replacement and use it across the repo

@rach-id
Copy link
Member

rach-id commented Oct 13, 2022

The QGB also rely on it to wait for signatures to be included in blocks. We will need to update that also

Edit: no longer relevant with new design

@evan-forbes evan-forbes added this to the Post-mainnet milestone Jan 31, 2023
@evan-forbes evan-forbes removed this from the Post-mainnet milestone Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants