Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize RetrieveBlockData #278

Closed
liamsi opened this issue Apr 10, 2021 · 2 comments
Closed

Optimize RetrieveBlockData #278

liamsi opened this issue Apr 10, 2021 · 2 comments

Comments

@liamsi
Copy link
Member

liamsi commented Apr 10, 2021 •
edited
Loading

Currently, we spin up a go-rountine per row/colum leaf that we want to sample in RetrieveBlockData. It might be more efficient (and more readable) to use the IPFS api for this.
Original discussion: #232 (comment)

Also related: #357
@liamsi liamsi mentioned this issue Apr 10, 2021
Merged
4 tasks
@evan-forbes evan-forbes mentioned this issue May 15, 2021
Closed
5 tasks
@Wondertan
Copy link
Member

@liamsi, can we close this in favour of https://github.com/celestiaorg/lazyledger-core/issues/429

@liamsi
Copy link
Member Author

liamsi commented Jun 23, 2021

OK, there is certainly more context in #429 already.

@liamsi liamsi closed this as completed Jun 23, 2021
@Wondertan Wondertan mentioned this issue Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liamsi @Wondertan