Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: Implement a /status endpoint for users to get basic information about the Node #118

Closed
renaynay opened this issue Oct 7, 2021 · 4 comments
Closed

rpc: Implement a /status endpoint for users to get basic information about the Node #118

renaynay opened this issue Oct 7, 2021 · 4 comments
Labels
area:rpc good first issue Good for newcomers

Comments

@renaynay
Copy link
Member

renaynay commented Oct 7, 2021

Implement a /status endpoint for users to get basic information about the Node, called NodeInfo.

Refer to /status endpoint from Tendermint RPC. Obviously celestia-node is still not developed enough to be able to provide most of the information returned by Tendermint's /status endpoint, but some information like:

  • Node's p2p information (listen address)
  • network that the node is on
@renaynay renaynay added good first issue Good for newcomers area:rpc labels Oct 7, 2021
@renaynay renaynay mentioned this issue Oct 8, 2021
Merged
@rach-id
Copy link
Member

rach-id commented Oct 12, 2021 •
edited
Loading

@renaynay I will be working at this issue.
I am curious about the network? Where is that supposed to be?
Thanks.

@renaynay
Copy link
Member Author

Hey @sweexordious ! I'm glad you're working on this issue - you can find the network in the p2p config here:

https://github.com/celestiaorg/celestia-node/blob/main/node/p2p/p2p.go#L52

@rach-id rach-id mentioned this issue Oct 13, 2021
Closed
@rach-id
Copy link
Member

rach-id commented Oct 13, 2021 •
edited
Loading

@renaynay Thanks for coming back to me.
Just opened a PR on this matter. Please take a look and let me know if any changes are needed.

@renaynay
Copy link
Member Author

Closing in favour of design described in #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rpc good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds status handler to RPC client rach-id/celestia-node
2 participants
@rach-id @renaynay