You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would need to run this against a chaos monkey / fault injection framework to absolutely reliably reproduce.
Expected result
store.put should not ignore f.Close errors.
Actual result
Errors that occur after file has been closed but before the filesystem syncs would be ignored due to the defer. In combination with the fact that we don't force a filesystem sync with fsync, this can cause a data loss and/or blockstore corruption.
Relevant log output
No response
Notes
No response
The text was updated successfully, but these errors were encountered:
Celestia Node version
v0.11.0-rc12
OS
darwin/arm64
Install tools
No response
Others
No response
Steps to reproduce it
Follow up from #2613, semi-related.
Would need to run this against a chaos monkey / fault injection framework to absolutely reliably reproduce.
Expected result
store.put
should not ignoref.Close
errors.Actual result
Errors that occur after file has been closed but before the filesystem syncs would be ignored due to the
defer
. In combination with the fact that we don't force a filesystem sync withfsync
, this can cause a data loss and/or blockstore corruption.Relevant log output
No response
Notes
No response
The text was updated successfully, but these errors were encountered: