Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edsstore put file handling refinement #2673

Closed
tuxcanfly opened this issue Sep 7, 2023 · 2 comments
Closed

edsstore put file handling refinement #2673

tuxcanfly opened this issue Sep 7, 2023 · 2 comments
Labels
bug Something isn't working external Issues created by non node team members

Comments

@tuxcanfly
Copy link
Contributor

Celestia Node version

v0.11.0-rc12

OS

darwin/arm64

Install tools

No response

Others

No response

Steps to reproduce it

Follow up from #2613, semi-related.

Would need to run this against a chaos monkey / fault injection framework to absolutely reliably reproduce.

Expected result

store.put should not ignore f.Close errors.

Actual result

Errors that occur after file has been closed but before the filesystem syncs would be ignored due to the defer. In combination with the fact that we don't force a filesystem sync with fsync, this can cause a data loss and/or blockstore corruption.

Relevant log output

No response

Notes

No response

@tuxcanfly tuxcanfly added the bug Something isn't working label Sep 7, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Sep 7, 2023
@walldiss
Copy link
Member

walldiss commented Sep 19, 2023

Errors in close will be logged since merge of #2612. If we happen to see any errors, I'll post an update

@renaynay
Copy link
Member

Can this be closed @walldiss ?

@ramin ramin closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues created by non node team members
Projects
None yet
Development

No branches or pull requests

4 participants