Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: allow subscribing to new blocks #2737

Closed
SuperFluffy opened this issue Sep 20, 2023 · 1 comment · Fixed by #3539
Closed

[Feature Request]: allow subscribing to new blocks #2737

SuperFluffy opened this issue Sep 20, 2023 · 1 comment · Fixed by #3539
Labels
enhancement New feature or request external Issues created by non node team members

Comments

@SuperFluffy
Copy link

SuperFluffy commented Sep 20, 2023

Implementation ideas

A nice feature would be to subscribe to new blocks under a target namespace, maybe something like blob.Subscribe that takes 1 or more namespaces. It would be great to receive the current height and a map of namespace -> [blob] (the RPC should return an empty map and/or list if no blocks were written).

At the moment we can use header.Subscribe and then extract the most recent height. We can then follow this up with blob.GetAll using height and a single [MyNamespace] as parameters.

This is fine and not too inconvient, but a direct subscription to blocks that avoids the extra RPC would be a good feature for a data availability layer.

@SuperFluffy SuperFluffy added the enhancement New feature or request label Sep 20, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Sep 20, 2023
@Wondertan
Copy link
Member

Thanks for the issue! We had something like this in mind for a while but never received any feature requests from any of teams. We should def do blob.Subsribe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Issues created by non node team members
Projects
None yet
2 participants