Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state): SubmitPayForBlob should detect timed out waiting for tx to be included in a block #3078

Open
vgonkivs opened this issue Jan 8, 2024 · 0 comments
Labels
area:state Related to fetching state and state execution

Comments

@vgonkivs
Copy link
Member

vgonkivs commented Jan 8, 2024

There is a use case when we can get timed out waiting for tx to be included in a block from core/app. This error means that the block is full but the tx is not paying enough fee to get in. This error can be confusing for the user, so instead of returning it, we can:

  1. Convert to ErrInsufficientFee(in case the user passed fee and gas limit as options)
  2. Increase the fee and try to re-submit the tx(in case the user uses DefaultSumitOptions and we calculate fee and gas limit on our side)
@vgonkivs vgonkivs added the area:state Related to fetching state and state execution label Jan 8, 2024
@renaynay renaynay changed the title state: SubmitPayForBlob should detect timed out waiting for tx to be included in a block feat(state): SubmitPayForBlob should detect timed out waiting for tx to be included in a block Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution
Projects
None yet
Development

No branches or pull requests

1 participant